Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled toot with media immediately creating a toot #9894

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire ClearlyClaire changed the title [WiP] Fix scheduled toot with media immediately creating a toot Fix scheduled toot with media immediately creating a toot Jan 21, 2019
@tateisu
Copy link
Contributor

tateisu commented Jan 21, 2019

I tried this PR on my test server, it works perfect.
also it allows my app to reuse media attachment when "delete and redraft" scheduled status. thx!

@mayaeh
Copy link
Contributor

mayaeh commented Jan 21, 2019

There seems to be no problem in the range I tried.
I think that this problem was fixed.
Thank you !

@Gargron Gargron merged commit 061feb6 into mastodon:master Jan 21, 2019
kedamaDQ pushed a commit to kedamaDQ/mastodon that referenced this pull request Jan 25, 2019
)

* Add test for not persisting status when attaching media to scheduled toot

* Prevent status used for validation from being persisted to the database

Fixes mastodon#9893

Thanks to tateisu for the help investigating this.
@ClearlyClaire ClearlyClaire deleted the fixes/scheduled-media branch March 14, 2019 15:46
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
)

* Add test for not persisting status when attaching media to scheduled toot

* Prevent status used for validation from being persisted to the database

Fixes mastodon#9893

Thanks to tateisu for the help investigating this.
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
)

* Add test for not persisting status when attaching media to scheduled toot

* Prevent status used for validation from being persisted to the database

Fixes mastodon#9893

Thanks to tateisu for the help investigating this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants