Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum visibility of local silenced users to unlisted #9583

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

ClearlyClaire
Copy link
Contributor

Fixes #9580

ApplicationRecord.transaction do
status = account.statuses.create!(text: text,
media_attachments: media || [],
thread: in_reply_to,
sensitive: (options[:sensitive].nil? ? account.user&.setting_default_sensitive : options[:sensitive]) || options[:spoiler_text].present?,
spoiler_text: options[:spoiler_text] || '',
visibility: options[:visibility] || account.user&.setting_default_privacy,
visibility: visibility,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does give away to the user that they are silenced. I thought you want to hook into the ActivityPub-facing JSON to force it there. Although you could argue that they can look at the ActivityPub JSON likewise to find out, so maybe this is the simplest solution...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can already to this by looking at the public timeline of their instance…?
Also, I'm not sure I see the point of silently silencing a local user. Shouldn't a decision about a local user be known to them?

@renatolond
Copy link
Contributor

I think this is a good way to treat this, to limit where their posts can reach. Though I agree it exposes that the user was silenced, and maybe plugging directly into federation code would be better. (but then from other instances they could have the same information, maybe, so 🤷🏽‍♂️)

In my instances I'm always a bit reticent to silence local users. It means I cannot see easily (without going to the admin interface) what they're posting anymore, but they keep posting. This brings the silencing closer to sandboxing, which I think it's what I would want for some cases.

@Gargron
Copy link
Member

Gargron commented Dec 24, 2018

Okay, now with #9519 communicating "your account is limited" to end-users it makes more sense for this change to limit post visibility in a way that's obvious to those end-users.

@Gargron Gargron merged commit 5f38799 into mastodon:master Dec 24, 2018
@ClearlyClaire ClearlyClaire deleted the fixes/local-silenced branch March 14, 2019 15:43
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants