Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to scrollable lists and media gallery #9501

Merged
merged 5 commits into from
Dec 12, 2018

Conversation

ClearlyClaire
Copy link
Contributor

Always display a scrollbar for components using ScrollableList, display “load more” whenever some list is known to have more items even if no items have been retrieved so far, and display a loading indicator in account gallery timelines on first load.

Fixes mastodon#9499 as well as empty timelines' scrollbar “blinking”
between loading state and empty state.
(Even though that codepath is probably never actually used…)
Fixes mastodon#9498

Display “load more” more consistently, add a loading indicator on first load.
@Gargron Gargron merged commit 55abff8 into mastodon:master Dec 12, 2018
@ClearlyClaire ClearlyClaire deleted the fixes/account-media-gallery branch March 14, 2019 14:39
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Always use the scrollable class for the ScrollList component

Fixes mastodon#9499 as well as empty timelines' scrollbar “blinking”
between loading state and empty state.

* Do not display empty message when the list is known to have more elements

Fixes mastodon#9500

* Fix LoadMore usage in account media gallery

(Even though that codepath is probably never actually used…)

* Make account media gallery more consistent with account timeline

Fixes mastodon#9498

Display “load more” more consistently, add a loading indicator on first load.

* Fix “load more” button when no data has been fetched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants