Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to dismiss desktop notifications permissions banner #15141

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 11, 2020

It may not persist between page reloads but it's better than nothing.

Because the only settings that are persisted, are persisted for every session of the web UI, and desktop notifications permission are specific to a single session only, it is not trivial to add persistence in this case.

@Gargron Gargron merged commit 4790a12 into master Nov 11, 2020
@Gargron Gargron deleted the fix-close-notifications-permissions-banner branch November 11, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants