Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze scroll position when a dropdown menu is open in the TL #14271

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Jul 8, 2020

Even if we do change the dropdown code to be position: fixed to fix the issue with single-column mode, it still makes sense to freeze TL scrolling to avoid the dropdown menu pointing at something different than the status it was originally open for.

I am not completely happy with using react-redux's connect in ScrollableList as it's a component, but that wouldn't be a first (e.g., StatusActionBar).

Peek 08-07-2020 22-13

@ClearlyClaire
Copy link
Contributor Author

ClearlyClaire commented Jul 8, 2020

Hmmm this is useful but I'm wrong, it doesn't fix #14266, as that's the “scroll to compensate” that causes the issue in single-column mode in the first place.

@brawaru
Copy link
Contributor

brawaru commented Jul 8, 2020

@ThibG wrong GIF in the description? 👀

@ClearlyClaire
Copy link
Contributor Author

@ThibG wrong GIF in the description? eyes

Indeed 😩

@Gargron Gargron merged commit 6fda3cb into mastodon:master Jul 9, 2020
abcang pushed a commit to abcang/mastodon that referenced this pull request Jul 11, 2020
…on#14271)

* Freeze scroll position when a dropdown menu is open in the TL

* Apply this to direct TL as well

* Fix case when mouse leaves the menu
shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request Dec 7, 2022
…on#14271)

* Freeze scroll position when a dropdown menu is open in the TL

* Apply this to direct TL as well

* Fix case when mouse leaves the menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants