Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to choose media thumbnail in web UI #14244

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jul 6, 2020

image

I wanted to do something fancier but can't reach any satisfying results for now. At the end of the day, the most important part is having the function at all, and I suppose it looks nice enough.

@Gargron Gargron force-pushed the feature-choose-cover-art-web-ui branch from 275bee0 to f0f4065 Compare July 6, 2020 23:20
@Gargron Gargron marked this pull request as ready for review July 6, 2020 23:21
@Gargron Gargron added the ui Front-end, design label Jul 6, 2020
@Gargron Gargron merged commit 06fc6a9 into master Jul 7, 2020
@Gargron Gargron deleted the feature-choose-cover-art-web-ui branch July 7, 2020 10:14
@SuperSandro2000
Copy link
Contributor

This is basically an invitation for trolls to put completely unrelated thumbnails on videos. I am not a fan of this.

@ClearlyClaire
Copy link
Contributor

I don't know, people could already engineer videos with a frame they would want to see as thumbnail.

@SuperSandro2000
Copy link
Contributor

I did no research but with this change it got a lot easier.

@brawaru
Copy link
Contributor

brawaru commented Jul 9, 2020

I agree with @ThibG, before this moment Mastodon extracted the first frame as thumbnail for the video. And I, in fact, used this here (the only thing is that I suck at ffmpeg and did not concat correctly, so it uses much more frames, which is visually noticeable). This PR just makes it easier for you to have such thumbnail without modifying the video.

yi0713 added a commit to yi0713/mastodon that referenced this pull request Jul 13, 2020
shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants