Fix WebUI pagination of following, followers, follow requests, blocks and mutes lists #13445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
changed the title
Gargron
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebUI sometimes made concurrent queries to the API for the same pages, and added the duplicate results in the same lists, resulting in duplicate results as well as “mysterious gaps” when some copies of a given item are detected as hidden by the intersection observer.
This change does not perform any deduplication (that shouldn't be needed if the queries are correct), but prevents concurrent queries to the same page by using the same
isLoadedmechanism as for other lists featuring pagination.