Fix old migrations failing because of strong_migrations update #12692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mastodon#12690 The `strong_migrations` update from ba2eac8 introduced a check for `change_column_null` specific to Postgres. This rejects old migrations. This commit just wraps old migrations with `safety_assured` to bypass this check. Alternatives would have been to: - Disable that check entirely (a possibility added in that same `strong_migrations` version) for Mastodon, but it makes sense to write new migrations without such a strong lock. - Rewrite the old migrations to do it in a way that do not require an exclusive lock. I thought fixing those old migrations for performance wasn't worth the pain. Also, if I understand correctly, the next version of `strong_migrations` is going to include a helper to do that. We could update those migrations at that point.
Gargron
approved these changes
Dec 26, 2019
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jan 6, 2020
Fixes mastodon#12768 Some migrations were overlooked in mastodon#12692
ykzts
pushed a commit
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12690
The
strong_migrationsupdate from ba2eac8introduced a check for
change_column_nullspecific to Postgres. This rejectsold migrations.
This commit just wraps old migrations with
safety_assuredto bypass thischeck. Alternatives would have been to:
strong_migrationsversion) for Mastodon, but it makes sense to write newmigrations without such a strong lock.
lock. I thought fixing those old migrations for performance wasn't worth the
pain. Also, if I understand correctly, the next version of
strong_migrationsis going to include a helper to do that. We could updatethose migrations at that point.