Add instance actor (second take) #11321
Conversation
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
from
9423fc2
to
9588c6b
Compare
| @@ -0,0 +1,48 @@ | |||
| - content_for :page_title do | |||
There was a problem hiding this comment.
I can't really tell how this is going to look from code alone but do we need a HTML page for this?
There was a problem hiding this comment.
The page is useful to let people know what this actor is about, as it may be confusing. Having it on a separate page allows people to know at a glance that it is a special user.
It looks like this:
There was a problem hiding this comment.
Should the url maybe just point to the /about page then? What I'm trying to avoid is the maintenance cost of another static page design because they've tended to be redesigned quite a few times so far.
There was a problem hiding this comment.
I don't think so, we really want to explain what this account is for. I should probably reword that description btw.
|
You should probably make |
Yes, I will do that, I just need to think about how to do cleanly, and I'd have to adjust the tests. |
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
4 times, most recently
from
b3534d8
to
f712c3f
Compare
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
from
cd3bef2
to
b3759ed
Compare
Use instance actor for forwarding reports, relay operations, and spam auto-reporting.
Following an instance actor might make sense, but we are not handling that right now, so auto-reject.
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
from
daec7be
to
d473be6
Compare
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
from
7b7a63c
to
9b0a4ba
Compare
|
Changed the instance actor profile URL to This has the added benefit of always returning json for the actor URI, thus not having to worry about the |
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
3 times, most recently
from
774e53f
to
3112f34
Compare
ClearlyClaire
force-pushed
the
features/instance-actor-v2
branch
from
3112f34
to
c6aec6e
Compare
So far, the English version of Mastodon has been VERY consistent about using the word "server" instead of "instance". This would actually be, as far as I know, the first time the word "instance" is used on the actual UI. This should be addressed should it not? |
* Add support for an instance actor * Skip username validation for local Application accounts * Add migration script to create instance actor * Make Codeclimate happy * Switch to id -99 for instance actor * Remove unused `icon` and `image` attributes from instance actor * Use if/elsif/else instead of return + ternary operator * Add instance actor to fresh installs * Use instance actor as instance representative Use instance actor for forwarding reports, relay operations, and spam auto-reporting. * Seed database in test environment * Fix single-user mode * Fix tests * Fix specs to accomodate for an extra `Account` * Auto-reject follows on instance actor Following an instance actor might make sense, but we are not handling that right now, so auto-reject. * Fix webfinger lookup and serialization for instance actor * Rename instance actor * Make it clear in the HTML view that the instance actor should not be blocked * Raise cache time for instance actor as there's no dynamic content * Re-use /about/more with a flash message for instance actor profile
#10457 but using an actual
Accountwith the following tricks:instance.tldas username, to make sure we're not hitting an existing usernameApplicationasactor_typeand0asidto uniquelyActorfieldsIt seems to work, I am not sure what may be missing but I haven't actually tested federating with it yet.