Fix language detection of non-latin alphabets even at few characters #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-language-detection-non-latin
branch
from
c25b57f
to
f5d4aa3
Compare
Gargron
force-pushed
the
fix-language-detection-non-latin
branch
from
f5d4aa3
to
0f5a9db
Compare
ykzts
approved these changes
Mar 15, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLD3 is unreliable on short text for latin alphabets, because a lot of languages share them. However, some languages have specific character sets, which makes detecting them more reliable even at short lengths. This PR adds an exception to the 140 characters threshold rule, so that we can reliably detect Japanese, Chinese, Hebrew, Korean, and some others.
Resolve #9760