Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poll update handler calling method was that was not available #10246

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Fix poll update handler calling method was that was not available #10246

merged 5 commits into from
Mar 12, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 12, 2019 •
edited
Loading

Fix #10241

@Gargron Gargron added bug Something isn't working work in progress Not to be merged, currently being worked on labels Mar 12, 2019
@Gargron
Copy link
Member Author

Gargron commented Mar 12, 2019

@ThibG I have not found the source for the DeliveryWorker problem yet 😕

@ClearlyClaire
Copy link
Contributor

@Gargron me neither

ClearlyClaire
ClearlyClaire requested changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you overlooked something (inline comment).
Otherwise LGTM.

app/lib/activitypub/activity/update.rb Outdated Show resolved Hide resolved
@Gargron Gargron merged commit 9f5b55a into master Mar 12, 2019
@Gargron Gargron deleted the fix-poll-update-handler branch March 12, 2019 22:16
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
@Gargron @hiyuki2578
Fix poll update handler calling method was that was not available (ma…
133529b 
…stodon#10246)

* Fix poll update handler calling method was that was not available

Fix regression from mastodon#10209

* Refactor VoteService

* Refactor ActivityPub::DistributePollUpdateWorker and optimize it

* Fix typo

* Fix typo
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
@Gargron
Fix poll update handler calling method was that was not available (ma…
c3ad0da 
…stodon#10246)

* Fix poll update handler calling method was that was not available

Fix regression from mastodon#10209

* Refactor VoteService

* Refactor ActivityPub::DistributePollUpdateWorker and optimize it

* Fix typo

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
bug Something isn't working work in progress Not to be merged, currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ClearlyClaire