Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use parentNode config anymore due to HTML5 data attribute support #102

Closed
mikeatlas opened this issue Nov 26, 2013 · 2 comments
Closed

Comments

@mikeatlas
Copy link

Per f5941492, the new ability to set the parentNode instead of just the DOM document element id regressed due to line 111 still assuming the document is the container:

var uel = document.getElementById(config.id);

You might look into adding a test suite (not just demo pages), as your demo for setting parentNode doesn't use the latest HTML5 code, which caused the regression. I really like Jasmine, personally.

@toorshia
Copy link
Owner

You are 10000% right.
This thing is steadily growing and getting out of my hands, and I still don't have an efficient process established to test new commits.

I am a complete novice, when it comes to setting up automatic tests of any sort - I am part designer - part coder.
Google is my friend I know that, but any help on getting me up to speed with jasmine is welcome :)

@toorshia
Copy link
Owner

Hiya,

This should work fine now. There's also a new custom node demo. There are four gauge creation cases: by constructor params and data-attribs, on DOM tree nodes, and the same for nodes outside of DOM tree.

Please check. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants