Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate github.com/docker/docker/pkg/fileutils and remove docker dependency from main go.mod #105

Closed
wants to merge 47 commits into from
Closed

Migrate github.com/docker/docker/pkg/fileutils and remove docker dependency from main go.mod #105

wants to merge 47 commits into from

Commits on Sep 30, 2014

  1. Move Matches() file path matching function into pkg/fileutils 

    This is the second of two steps to break the archive package's
dependence on utils so that archive may be moved into pkg. `Matches()`
is also a good candidate pkg in that it is small, concise, and not
specific to docker internals

Signed-off-by: Rafe Colton <rafael.colton@gmail.com>
    @rafecolton
    rafecolton committed Sep 30, 2014
    Configuration menu
    Copy the full SHA
    cf85e14 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2014

  1. Use logrus everywhere for logging 

    Fixed #8761

Signed-off-by: Alexandr Morozov <lk4d4@docker.com>
    @LK4D4
    LK4D4 committed Oct 24, 2014
    Configuration menu
    Copy the full SHA
    6997122 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2014

  1. Merge pull request #9345 from jfrazelle/bump_v1.4.0 

    Bump version to 1.4.0
    Jessie Frazelle committed Dec 12, 2014
    Configuration menu
    Copy the full SHA
    3f34172 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9623 from jfrazelle/merge_release_v1.4.0 

    Merge release v1.4.0
    @tiborvass
    tiborvass committed Dec 12, 2014
    Configuration menu
    Copy the full SHA
    c40acfb View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2015

  1. Replace aliased imports of logrus, fixes #11762 

    Signed-off-by: Antonio Murdaca <me@runcom.ninja>
    Antonio Murdaca committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    adf480f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2015

  1. Refactor ultis/utils_daemon, fixes #11908 

    Signed-off-by: Antonio Murdaca <me@runcom.ninja>
    Antonio Murdaca committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    729de31 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2015

  1. Refactor utils/utils, fixes #11923 

    Signed-off-by: Antonio Murdaca <me@runcom.ninja>
    Antonio Murdaca committed Apr 13, 2015
    Configuration menu
    Copy the full SHA
    0a27ce5 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2015

  1. add support for exclusion rules in dockerignore 

    Signed-off-by: Dave Goodchild <buddhamagnet@gmail.com>
    @buddhamagnet
    buddhamagnet committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    efa3920 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2015

  1. Add coverage on pkg/fileutils 

    Should fix #11598

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
    @vdemeester
    vdemeester committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    12de81b View commit details
    Browse the repository at this point in the history

Commits on May 30, 2015

  1. Allow .dockerignore to ignore everything 

    Change CLI error msg because it was too specific and didn't make sense
when there were errors not related to inaccessible files.

Removed some log.Error() calls since they're not really errors we should
log. Returning the error will be enough.

Closes: #13417

Signed-off-by: Doug Davis <dug@us.ibm.com>
    Doug Davis committed May 30, 2015
    Configuration menu
    Copy the full SHA
    45ebe6e View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2015

  1. linting changes 

    Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
    @unclejack
    unclejack committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    c1c4092 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #13961 from unclejack/linting_changes 

    linting changes
    @calavera
    calavera committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    bcd8472 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2015

  1. Fix copy from a "created" container. Fixes #14420 

    Signed-off-by: Lei Jitang <leijitang@huawei.com>
    @coolljt0725
    coolljt0725 committed Jul 8, 2015
    Configuration menu
    Copy the full SHA
    b1e4b70 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2015

  1. Add missing tests and docs for pkg/fileutils 

    Signed-off-by: Vincent Demeester <vincent@sbr.pm>
    @vdemeester
    vdemeester committed Jul 12, 2015
    Configuration menu
    Copy the full SHA
    0ef7a97 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2015

  1. Windows: Fix warning on info 

    Signed-off-by: John Howard <jhoward@microsoft.com>
    John Howard committed Sep 18, 2015
    Configuration menu
    Copy the full SHA
    7a793b5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #16407 from Microsoft/10662-fixinfoprocerror 

    Windows: Fix error in daemon log on info
    Jess Frazelle committed Sep 18, 2015
    Configuration menu
    Copy the full SHA
    5874684 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2015

  1. Support multi-dir wildcards in .dockerignore 

    Closes #13113

Signed-off-by: Doug Davis <dug@us.ibm.com>
    Doug Davis committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    0fc3ada View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2015

  1. Fix typos found across repository 

    Signed-off-by: Justas Brazauskas <brazauskasjustas@gmail.com>
    @jutaz
    jutaz committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    a2acf9a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #18623 from jutaz/bugfix/typos 

    Bugfix - Typos
    @runcom
    runcom committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    35f2440 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2016

  1. Windows CI: Fixes panic in test-unit for FileUtils 

    Signed-off-by: John Howard <jhoward@microsoft.com>
    John Howard committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    84a541e View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2016

  1. Windows CI: Turn off failing unit test pkg\fileutils 

    Signed-off-by: John Howard <jhoward@microsoft.com>
    John Howard committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    78e8dc8 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. fix typos 

    Signed-off-by: allencloud <allen.sun@daocloud.io>
    @allencloud
    allencloud committed May 6, 2016
    Configuration menu
    Copy the full SHA
    357fbde View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2016

  1. fix typos 

    Signed-off-by: allencloud <allen.sun@daocloud.io>
    @allencloud
    allencloud committed Jul 23, 2016
    Configuration menu
    Copy the full SHA
    ab6836d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2016

  1. all: use strings.Contains instead Index 

    Signed-off-by: Elena Morozova <lelenanam@gmail.com>
    @lelenanam
    lelenanam committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    92cb27b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2016

  1. Fix use of **/ in .dockerignore 

    .dockerignore pattern of **/.foo incorrectly matched **/bar.foo
because **/.foo was getting converted into a .*\.foo regex
instead of (.*/)*\.foo

Closes #29014

Signed-off-by: Doug Davis <dug@us.ibm.com>
    Doug Davis committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    94abe55 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2017

  1. Fix inefficient file paths filter 

    Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
    @tonistiigi
    tonistiigi committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    05da6ee View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. pkg/file{utils,notify}: don't compare to bool 

    Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
    @unclejack
    unclejack committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    3590d84 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2017

  1. Enable a unit test on windows. 

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Apr 21, 2017
    Configuration menu
    Copy the full SHA
    e1cdf57 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Update logrus to v1.0.1 

    Fixes case sensitivity issue

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
    @dmcgowan
    dmcgowan committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    32ab3cb View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. Add goimports to linters. 

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    ddcb242 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Add canonical import comment 

    Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    cd692c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Automated migration using 

    gty-migrate-from-testify --ignore-build-tags

Signed-off-by: Daniel Nephin <dnephin@docker.com>
    @dnephin
    dnephin committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    aeae3e8 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2018

  1. Fix typos 

    Signed-off-by: chenyuzhu <chenyuzhi@oschina.cn>
    @skyc024
    skyc024 committed May 16, 2018
    Configuration menu
    Copy the full SHA
    6b3b3d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. Update tests to use gotest.tools 👼 

    Signed-off-by: Vincent Demeester <vincent@sbr.pm>
    @vdemeester
    vdemeester committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    bf06bf6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #37243 from vdemeester/gotestyourself-with-tools 

    Update gotestyourself to gotest.tools
    Vincent Demeester committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    31861b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. Remove duplicated words in pkg files 

    Signed-off-by: mooncake <xcoder@tenxcloud.com>
    @mooncak
    mooncak committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    84a1066 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. gosec: add ignore comments for reported issues that can be ignored 

    ```
builder/remotecontext/remote.go:48:        G107: Potential HTTP request made with variable url (gosec)
builder/remotecontext/git/gitutils.go:145: G107: Potential HTTP request made with variable url (gosec)
builder/remotecontext/git/gitutils.go:147: G107: Potential HTTP request made with variable url (gosec)
pkg/fileutils/fileutils_test.go:185:       G303: File creation in shared tmp directory without using ioutil.Tempfile (gosec)
pkg/tarsum/tarsum_test.go:7:               G501: Blacklisted import `crypto/md5`: weak cryptographic primitive (gosec)
pkg/tarsum/tarsum_test.go:9:               G505: Blacklisted import `crypto/sha1`: weak cryptographic primitive (gosec)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    e2f6f7e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #39668 from thaJeztah/replace_gometalinter 

    Replace gometalinter with golangci-lint
    @yongtang
    yongtang committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a3c9386 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. bump gotest.tools v3.0.1 for compatibility with Go 1.14 

    full diff: gotestyourself/gotest.tools@v2.3.0...v3.0.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    e67d934 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. pkg/fileutils: TestMatches: remove cases no longer valid for go1.16 

    These tests were no longer valid on Go 1.16; related to https://tip.golang.org/doc/go1.16#path/filepath

> The Match and Glob functions now return an error if the unmatched part of
> the pattern has a syntax error. Previously, the functions returned early on
> a failed match, and thus did not report any later syntax error in the pattern.

Causing the test to fail:

    === RUN   TestMatches
        fileutils_test.go:388: assertion failed: error is not nil: syntax error in pattern: pattern="a\\" text="a"
    --- FAIL: TestMatches (0.00s)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed May 18, 2021
    Configuration menu
    Copy the full SHA
    0303540 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. pkg/fileutils: PatternMatcher.Matches(): remove debug logging 

    Trying to avoid logging code in "libraries" used elsewhere.
If this debug log is important, it should be easy to add in code
that's calling it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b340094 View commit details
    Browse the repository at this point in the history

  2. Migrate github.com/docker/docker/pkg/fileutils 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    35f6224 View commit details
    Browse the repository at this point in the history

  3. filematch: update package name 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a8a9249 View commit details
    Browse the repository at this point in the history

  4. filematch: remove utilities we don't use 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    85eadbf View commit details
    Browse the repository at this point in the history

  5. replace github.com/docker/docker/pkg/fileutils with filematch 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    cab31cd View commit details
    Browse the repository at this point in the history

  6. bench: make separate module 

    This package only contains testing / benchmarking code,
so dependencies needed for this package should not be in
the main go.mod.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    eaffca0 View commit details
    Browse the repository at this point in the history

  7. filematch: remove use of gotest.tools 

    It was only used for very minimal checks, so removing it
to not have this as a dependency.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    82bb6d3 View commit details
    Browse the repository at this point in the history