Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker dependency to 21.xx-dev (master), and update to go 1.16 #104

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

thaJeztah
Copy link
Collaborator

@thaJeztah thaJeztah commented Jun 9, 2021

  • hack/dockerfiles: switch to syntax dockerfile/1.2

  • hack/dockerfiles: use GO_VERSION for linter and go mod validation
    This allows the version to be set through a build-arg, and makes sure that the linter lints on the expected go version.

    Note that go mod results may differ between go versions. If this becomes a problem, we should use a fixed version for that validation (added a comment in the bakefile).

  • Update default go version to 1.16

  • go.mod: github.com/containerd/contiunity v0.1.0
    full diff: containerd/continuity@968621f...v0.1.0

  • go.mod: update docker to master (v21.xx-dev), post-libnetwork integration

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title update docker dependency to 21.xx-dev (master), and update dockerfile go versions update docker dependency to 21.xx-dev (master), and update to go 1.16 Jun 9, 2021
This allows the version to be set through a build-arg, and makes sure that
the linter lints on the expected go version.

Note that go mod results may differ between go versions. If this becomes a
problem, we should use a fixed version for that validation (added a comment
in the bakefile).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: containerd/continuity@968621f...v0.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…tion

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Collaborator Author

@tonistiigi PTAL

@tonistiigi tonistiigi merged commit f2e4606 into tonistiigi:master Jun 9, 2021
@thaJeztah thaJeztah deleted the bump_engine_master branch June 9, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants