Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in submitTransactions #128

Closed
ctnchain opened this issue May 3, 2024 · 0 comments
Closed

Bug in submitTransactions #128

ctnchain opened this issue May 3, 2024 · 0 comments
Assignees
@mrz1836
Labels
bug-P2 Medium rated bug, affects a few

Comments

@ctnchain
Copy link

ctnchain commented May 3, 2024

Describe the bug
There are a bug in the method submitTransactions, precisely in line

submit_transactions.go:109

In the call of the method ActionRouteByAPIType It should use SubmitTxs instead of SubmitTx. This mistake make the send transactions actually send the data to the endpoint /mapi/tx for a batch of transactions.

To Reproduce
Steps to reproduce the behavior:

  1. Just turn on mapi running
  2. Use Minercraft client to send batch of transactions SubmitTransactions
  3. Mapi will return the 400 error that it doesn't understand the structure of the json in the request

Expected behavior
After the fix, the Minercraft should work well with the method SubmitTransactions
@mrz1836 mrz1836 added the bug-P2 Medium rated bug, affects a few label May 3, 2024
@mrz1836 mrz1836 closed this as completed in a3e4b94 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrz1836 mrz1836

Labels
bug-P2 Medium rated bug, affects a few
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrz1836 @ctnchain