Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image->data change #33

Open
decarlof opened this issue May 7, 2019 · 2 comments
Open

image->data change #33

decarlof opened this issue May 7, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@decarlof
Copy link
Member

decarlof commented May 7, 2019

I realized that the pull request changing image->data may create some confusion because there are some variable derived from data called image (see imageTag, imageTag_label etc.).

Also there are some locations, for example in the old 2IDE HDF files in file_loader.py, still showing

self.dataTag.addItem('images')

I propose to change all variable derived from data as dataXXX

@decarlof decarlof added the enhancement New feature or request label May 7, 2019
@sichendart
Copy link
Contributor

self.dataTag.addItem('images') is for legacy. In the new hdf, "image" changes to "data", but not in the old files.

@decarlof
Copy link
Member Author

decarlof commented May 8, 2019

ok that makes sense. I was also concerned about

    `img_tag = self.imageTag.currentText()`
    `data_tag = self.dataTag.currentText()`
    `self.parent.params.image_tag = self.imageTag.currentText()`
   ` self.parent.params.data_tag = self.dataTag.currentText()`

in the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants