Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart does not inject resources correctly #695

Closed
tomkerkhove opened this issue Sep 2, 2019 · 4 comments
Closed

Helm chart does not inject resources correctly #695

tomkerkhove opened this issue Sep 2, 2019 · 4 comments
Labels
bug Something isn't working helm All issues related to Helm
Milestone

Comments

@tomkerkhove
Copy link
Owner

When given the following input to our Helm chart:

metrics:
  - name: promitor_demo_servicebusqueue_queue_size
    description: "Amount of active messages of the 'orders' queue (determined with ServiceBusQueue provider)"
    resourceType: ServiceBusQueue
    azureMetricConfiguration:
      metricName: ActiveMessages
      aggregation:
        type: Average
        # Optionally override the default aggregation interval (metricDefaults.aggregation.interval)
        interval: 00:15:00
    resources:
      - namespace: promitor-messaging
        queueName: orders

It will not correctly inject the metrics in the config map:

metrics:
  - azureMetricConfiguration:
      aggregation:
        interval: "00:15:00"
        type: Average
      metricName: ActiveMessages
    description: Amount of active messages of the 'orders' queue (determined with ServiceBusQueue
      provider)
    name: promitor_demo_servicebusqueue_queue_size
    resourceType: ServiceBusQueue
    resources:
    - namespace: promitor-messaging
      queueName: orders

Note the lack of a tab for the resource

The issue will lie in our tpl statement I think:
{{ tpl $metrics . | indent 6 }}

Relates to #513

@tomkerkhove tomkerkhove added bug Something isn't working helm All issues related to Helm labels Sep 2, 2019
@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Sep 2, 2019
@tomkerkhove
Copy link
Owner Author

Have you seen this before @lee0c ?

@tomkerkhove
Copy link
Owner Author

This is not a bug but PEBKAC

@lee0c
Copy link
Contributor

lee0c commented Sep 4, 2019

glad you sorted this before I even got a chance to look!

@tomkerkhove
Copy link
Owner Author

tomkerkhove commented Sep 4, 2019

Thanks anyway @lee0c !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm All issues related to Helm
Projects
None yet
Development

No branches or pull requests

2 participants