Service Bus Queues should be able to scrape all queues in namespace, not just one

[tomkerkhove]

Service Bus Queues should be able to scrape all queues in namespace, not just one.

It should annotate all queues that it scraped with a entity_name label in Prometheus endpoint.

Relates to #513 and was suggested in this comment by @marcinbudny

Checklist

• Make queueName optional in the configuration
• Scrape all queues if no queue name was configured
• Always apply entity_name label, even if queueName was configured for consistency reasons

[tomkerkhove]

One thing we'll need to evaluate is if we can get it out of the box or if this means increasing required permissions for our Azure AD app.

If that is the case we'll need to see if it's worth it.

[ChristianEder]

I am currently struggling with a similar issue, but I'm not sure if it is totally the same: I cannot get service bus queue metrics for more than 1 queue. I tried 2 things:

1. Using a ServiceBusQueue scraper with multiple resources:

- name: azure_service_bus_active_messages
  description: "Count of active messages per queue / topic"
  resourceType: ServiceBusQueue
  azureMetricConfiguration:
    metricName: ActiveMessages
    aggregation:
      type: Average
  resources:
  - namespace: my-namespace
    queueName: queue1
  - namespace:  my-namespace
    queueName: queue2
  - namespace:  my-namespace
    queueName: queue3

2. Using a Generic scraper with multiple resources, using filters:

- name: azure_service_bus_deadlettered_messages
  description: "Count of dead-lettered messages per queue / topic"
  resourceType: Generic
  azureMetricConfiguration:
    metricName: DeadletteredMessages
    aggregation:
      type: Average
  resources:
  - resourceUri: Microsoft.ServiceBus/namespaces/my-namespace
    filter: EntityName eq 'queue1'
  - resourceUri: Microsoft.ServiceBus/namespaces/my-namespace
    filter: EntityName eq 'queue2'
  - resourceUri: Microsoft.ServiceBus/namespaces/my-namespace
    filter: EntityName eq 'queue3'

The 1) approach leads to only the metrics for queue3 being reported, the 2) approach to only the unfiltered, total sum of DeadletteredMessages being reported. Is this a known issue or am I doing something wrong here?

[tomkerkhove]

Hm that feels like a bug, would you mind creating a new issue for this please? Sorry for this 😐

[ChristianEder]

Done: #1050