-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide integration with Azure Monitor #4
Labels
feature
All issues that are new features
integration:azure-monitor
All issues related to Azure Monitor integration
Milestone
Comments
tomkerkhove
added
integration:azure-monitor
All issues related to Azure Monitor integration
feature
All issues that are new features
labels
Feb 20, 2018
This was referenced Mar 7, 2018
Current proposal for configuration: azureConfiguration:
resourceGroupName: foo
subscriptionId: bar
metrics:
# v1.0
- name: "queue-size"
description: "Size of the 'myqueue' queue"
namespace: "myNamespace"
queueName: "myqueue"
resourceType: ServiceBusQueue
# Supported in later version - This will compose the following URL to query (subscriptions/abc/resourceGroups/xyz/providers/Microsoft.ServiceBus/namespaces/monitor-integration)
- name: "queue-size-generic" # Metric without description
resourceType: Generic
resourceProvider: "Microsoft.ServiceBus"
resourceSuffix: "namespaces/monitor-integration" # Provide better name for this
filterExpression: "EntityName eq 'myqueue'"
resourceGroupName: xyz # Overrides default Azure configuration
subscriptionId: abc # Overrides default Azure configuration |
This is currently what you need to query for Azure Service Bus: azureMetadata:
tenantId: tenant-x
subscriptionId: foo
resourceGroupName: bar
metrics:
# v1.0
- name: demo_queue_size
description: "Size of the 'myqueue' queue"
namespace: myNamespace
azureMetricName: ActiveMessages
azureMetricAggregation: Average
queueName: myqueue
resourceType: ServiceBusQueue However, I don't like the names for |
Change the structure to the following approach: azureMetadata:
tenantId: tenant-x
subscriptionId: foo
resourceGroupName: bar
metrics:
# v1.0
- name: demo_queue_size
description: "Size of the 'myqueue' queue"
resourceType: ServiceBusQueue
namespace: myNamespace
queueName: myQueue
azureMetricConfiguration:
metricName: Size
aggregation: Average This should be more readable than before |
Scraping Azure Monitor works but it needs some improvements. |
First rough release is ready ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
All issues that are new features
integration:azure-monitor
All issues related to Azure Monitor integration
Provide integration with Azure Monitor where it will automatically query the Azure Monitor REST API for a set of metrics and expose them via the scrape endpoint.
Depends on #3.
Specifications
Configuration
Metrics to scrape:
Scrape frequency:
PROMITOR_SCRAPE_SCHEDULE
Azure authentication:
PROMITOR_AUTH_APPID
PROMITOR_AUTH_APPKEY
The text was updated successfully, but these errors were encountered: