-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable limit for metrics with multiple dimensions #1595
Comments
Ha, interesting! So you always get 10 results and nothing more? Good point, I'll try to figure it out. |
Ideally you get everything most probably? |
Promitor currently only shows the metrics for 10 backend pools from an Application Gateway instance, even though there are over 30 pools in our environment. |
Makes sense, I'll test it that way - Thanks a lot! |
Looks like an API parameter that we'll specify - https://docs.microsoft.com/en-us/rest/api/monitor/metrics/list#uri-parameters |
Ok, turns out we can configure it here: promitor/src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs Lines 205 to 209 in e1fdb94
I'll get started on this |
I presume you don't want to configure the maximum amount or would you? |
You mean just set the parameter to "maxint32" in the code? That would probably work, but I can imagine that there are edge cases where this is not desired. |
I was thinking the same so that's perfect! |
So this is what it would look like: version: v1
azureMetadata:
tenantId: ABC
subscriptionId: XYZ
resourceGroupName: promitor
metricDefaults:
aggregation:
interval: 00:05:00
labels:
geo: china
environment: dev
scraping:
# Every minute
schedule: "0 * * ? * *"
metrics:
- name: promitor_demo_servicebus_messagecount_discovered
description: "Average percentage of memory usage on an Azure App Plan"
resourceType: ServiceBusNamespace
labels:
geo: europe
app: promitor
azureMetricConfiguration:
metricName: ActiveMessages
+ limit: 100 # Default: 10 000
aggregation:
type: Average
resources:
- namespace: promitor-messaging What do you think? I didn't add it to version: v1
azureMetadata:
tenantId: c8819874-9e56-4e3f-b1a8-1c0325138f27
subscriptionId: 0f9d7fea-99e8-4768-8672-06a28514f77e
resourceGroupName: promitor
metricDefaults:
+ limit: 100 # Default: None
aggregation:
interval: 00:05:00
labels:
geo: china
environment: dev
scraping:
# Every minute
schedule: "0 * * ? * *"
metrics:
- name: promitor_demo_servicebus_messagecount_discovered
description: "Average percentage of memory usage on an Azure App Plan"
resourceType: ServiceBusNamespace
labels:
geo: europe
app: promitor
azureMetricConfiguration:
metricName: ActiveMessages
+ limit: 1000 # Default: 10 000
aggregation:
type: Average
resources:
- namespace: promitor-messaging |
This is an awesome improvement 😃 I'm always a little concerned with changing default values, but in this case it totally makes sense, because most users certainly expect Promitor to return all metrics. |
Yes, that's the only reason why it's going up indeed. Do you want the metric defaults or not perse? |
A configurable limit in "metricDefaults" doesn't hurt, but I think most people will certainly never change this limit (myself included) 😉 |
Proposal
I was wondering why Promitor does not deliver all metrics for some of our services. Looks like the default limit (at least in the portal) is 10:
Unfortunately I didn't find any configuration option for the limit in Promitor, therefore this feature request.
Component
Scraper
Contact Details
No response
The text was updated successfully, but these errors were encountered: