New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that removed resources are no longer scraped during the next run #1244

Closed

tomkerkhove opened this issue Aug 27, 2020 · 1 comment · Fixed by #1383

Labels

agents:discovery-agent

Milestone

Scraper - v2.0.0

Owner

tomkerkhove commented Aug 27, 2020

Verify that removed resources are no longer scraped during the next run.

Scenario is:

Add resource
Run discovery
Scrape metrics (incl. that resource)
Remove resource
Run discovery
Scrape metrics (excl. that resource)

tomkerkhove added the agents:discovery-agent label

tomkerkhove added this to the Scraper - v2.0.0 milestone

Owner Author

tomkerkhove commented Nov 26, 2020

It works as expected - The resource is no longer scraped but Prometheus metrics are still served, but with an older timestamp

tomkerkhove mentioned this issue

docs: Document how Promitor handles removed resources #1383

Merged

tomkerkhove closed this as completed in #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment