From 952d82561fc18b48ed99daabcb956c34112f1200 Mon Sep 17 00:00:00 2001 From: Tom Kerkhove Date: Thu, 24 Jan 2019 18:00:30 +0100 Subject: [PATCH] Improve logging Signed-off-by: Tom Kerkhove --- samples/promitor-sample.yaml | 2 +- src/Promitor.Core.Scraping/Scraper.cs | 2 +- .../Scheduling/AzureMonitorScrapingTask.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/samples/promitor-sample.yaml b/samples/promitor-sample.yaml index 4b5942c81..7e9aa4620 100644 --- a/samples/promitor-sample.yaml +++ b/samples/promitor-sample.yaml @@ -4,7 +4,7 @@ azureMetadata: resourceGroupName: promitor metricDefaults: aggregation: - interval: 00:07:00 + interval: 00:05:00 metrics: - name: demo_generic_queue_size description: "Amount of active messages of the 'myqueue' queue (determined with Generic provider)" diff --git a/src/Promitor.Core.Scraping/Scraper.cs b/src/Promitor.Core.Scraping/Scraper.cs index bf7c62bf4..260fe9726 100644 --- a/src/Promitor.Core.Scraping/Scraper.cs +++ b/src/Promitor.Core.Scraping/Scraper.cs @@ -80,7 +80,7 @@ public async Task ScrapeAsync(MetricDefinition metricDefinition) var aggregationType = metricDefinition.AzureMetricConfiguration.Aggregation.Type; var foundMetricValue = await ScrapeResourceAsync(castedMetricDefinition, aggregationType, aggregationInterval); - _logger.LogInformation("Found value '{MetricValue}' for metric '{MetricName}'", foundMetricValue, metricDefinition.Name); + _logger.LogInformation("Found value '{MetricValue}' for metric '{MetricName}' with aggregation interval '{AggregationInterval}'", foundMetricValue, metricDefinition.Name, aggregationInterval); var gauge = Metrics.CreateGauge(metricDefinition.Name, metricDefinition.Description); gauge.Set(foundMetricValue); diff --git a/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs b/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs index 51af8a1ce..1395b622d 100644 --- a/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs +++ b/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs @@ -47,7 +47,7 @@ public async Task ExecuteAsync(CancellationToken cancellationToken) private async Task ScrapeMetric(AzureMetadata azureMetadata, MetricDefaults metricDefaults, MetricDefinition metricDefinitionDefinition) { - _logger.LogInformation("Scraping '{metricName}' for resource type '{resourceType}'", metricDefinitionDefinition.Name, metricDefinitionDefinition.ResourceType); + _logger.LogInformation("Scraping '{MetricName}' for resource type '{ResourceType}'", metricDefinitionDefinition.Name, metricDefinitionDefinition.ResourceType); var scraper = MetricScraperFactory.CreateScraper(metricDefinitionDefinition.ResourceType,azureMetadata, metricDefaults, _logger,_exceptionTracker); await scraper.ScrapeAsync(metricDefinitionDefinition);