Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denv passing through init even though deduced config is different from requested init #151

Closed
tomeichlersmith opened this issue Feb 14, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@tomeichlersmith
Copy link
Owner

Describe the bug
denv doesn't complain when init is run that would require overwriting but is instructed to not overwrite.
The problem here is not that denv refuses to over{write,ride}, its that the user is not told that the skipping is done.

To Reproduce

tom@zuko:/tmp/tmp.uZFZubM2sH$ denv init alpine:3.19
tom@zuko:/tmp/tmp.uZFZubM2sH$ mkdir subdir
tom@zuko:/tmp/tmp.uZFZubM2sH$ cd subdir
tom@zuko:/tmp/tmp.uZFZubM2sH/subdir$ denv init --no-over alpine:3.20 /tmp/tmp.uZFZubM2sH/subdir
tom@zuko:/tmp/tmp.uZFZubM2sH/subdir$ denv config print 
denv_workspace="/tmp/tmp.uZFZubM2sH"
denv_name="tmp.uZFZubM2sH"
denv_image="alpine:3.19"
denv_mounts=""
denv_shell="/bin/bash -i"
denv_network="true"
podman version 3.4.4

Expected behavior
I would like denv to fail when running denv init --no-over --no-mkdir owner/repo:tag /full/path/to/workspace if the deduced already-existent denv is not /full/path/to/workspace.

Additional context
LDMX-Software/ldmx-sw#1472 (comment)

@tomeichlersmith tomeichlersmith added the bug Something isn't working label Feb 14, 2025
@tomeichlersmith
Copy link
Owner Author

Ended up being easier than I was worried about, resolved by 5c3766b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant