-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential fragment directive parsing bugs #2
Comments
Do you want to PR this in? Asking since you were interested in contributing on Twitter. |
Yeah I can do that later |
I ended up quite busy today. I'll definitely try to contribute this weekend though |
Oh I hadn't realized that this syntax was not compatible with the To re-use the |
In the case of media, the aim was to reuse the existing syntax of WebAnnotations. See https://github.com/WICG/scroll-to-text-fragment/blob/main/EXTENSIONS.md#proposed-solution and https://www.w3.org/TR/2017/NOTE-selectors-states-20170223/#FragmentSelector_frag. |
This fragment directive parsing code looks flimsy and doesn't correctly handle multiple directives. The selector validation logic is fine but the code which extracts the fragment directives seems problematic.
Feel free to copy this getFragmentDirectives() function. I am dedicating that entire code snippet block to the public domain.
The text was updated successfully, but these errors were encountered: