Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticable latency when navigating menus with arrow keys #973

Closed
FichteFoll opened this issue Sep 2, 2024 · 2 comments
Closed

Noticable latency when navigating menus with arrow keys #973

FichteFoll opened this issue Sep 2, 2024 · 2 comments

Comments

@FichteFoll
Copy link

Since updating to 5.4.0 just now, I noticed that there is a small delay between hitting arrow keys to navigate menus and the menu updating. I also did a direct comparison with 5.2.0 and that feels much snappier.

This also applies to hovering items with the pointer, but it's less of an issue there since you are in direct control of the pointer and the pointer itself updates fast enough to your movements.

@FichteFoll
Copy link
Author

FichteFoll commented Sep 2, 2024

Just saw that this is also discussed in #970 (didn't show up when I was looking for duplicate issues).

@tomasklaen
Copy link
Owner

No it's fine, I think this is a more appropriate place to discuss it anyway since it's a valid concern.

Are you sure about that? It's most certainly not like this in any text editor I've used in the last decade and I don't see why it would be. Which applications are you thinking of that operate on keyup?

It's a standard practice to bind event handlers to full key presses, at least on the web front end. There's some shortcut stuff you can't implement if you bind to downs, but that is rarely used. I myself usually use only downs as it feels faster. I assumed I had some reason to bind to up in recent menu shortcut handling refactor, but looking at the code I don't see any, so I'll set it back to downs.

Thx for raising this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants