Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render more comprehensible documentation for join/try_join macros #6775

Closed
Darksonn opened this issue Aug 13, 2024 · 3 comments · Fixed by #6841
Closed

Render more comprehensible documentation for join/try_join macros #6775

Darksonn opened this issue Aug 13, 2024 · 3 comments · Fixed by #6841
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate M-macros Module: macros in the main Tokio crate T-docs Topic: documentation

Comments

@Darksonn
Copy link
Contributor

This issue is to make the same change as #6468 to the join! and try_join! macros.
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Topic: documentation A-tokio Area: The main tokio crate E-medium Call for participation: Experience needed to fix: Medium / intermediate M-macros Module: macros in the main Tokio crate labels Aug 13, 2024
@Rustin170506
Copy link
Contributor

I will try to improve it.

@Rustin170506 Rustin170506 mentioned this issue Sep 2, 2024
Merged
@Darksonn
Copy link
Contributor Author

Darksonn commented Sep 6, 2024

This was fixed for the join! macro, but still needs to be changed for try_join!.

@Rustin170506
Copy link
Contributor

Yes. I will send another PR for it.

@Rustin170506 Rustin170506 mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate M-macros Module: macros in the main Tokio crate T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macros: render more comprehensible documentation for try_join! Rustin170506/tokio
2 participants
@Darksonn @Rustin170506