Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit T: Sized requirement from UnsafeCell #222

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Remove implicit T: Sized requirement from UnsafeCell #222

merged 1 commit into from
Sep 7, 2021

Conversation

WaffleLapkin
Copy link
Contributor

std's UnsafeCell doesn't have T: Sized requirement, so I don't see why the loom version should be different.

hawkw
hawkw approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

i think the missing ?Sized bound may have been an artifact of a previous implementation where the data was not stored in a std UnsafeCell, but I may be wrong about that. it could have just been an oversight...

@Darksonn Darksonn merged commit 26d0d7a into tokio-rs:master Sep 7, 2021
@WaffleLapkin WaffleLapkin deleted the maybesized-unsafecell branch September 7, 2021 18:40
@Darksonn Darksonn mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WaffleLapkin @hawkw @Darksonn