Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify BufPut::put_int behavior #486

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

stepancheg
Copy link
Contributor

  • writes low bytes, discards high bytes
  • panics if nbytes is greater than 8

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the late review!

src/buf/buf_mut.rs Outdated Show resolved Hide resolved
* writes low bytes, discards high bytes
* panics if `nbytes` is greater than 8
@stepancheg
Copy link
Contributor Author

Fixed doc. Thanks!

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit fa9cbf1 into tokio-rs:master Aug 8, 2021
@stepancheg stepancheg deleted the clarify-put-int branch August 8, 2021 21:54
@Darksonn Darksonn mentioned this pull request Aug 25, 2021
lelongg pushed a commit to lelongg/bytes that referenced this pull request Jan 9, 2023
* writes low bytes, discards high bytes
* panics if `nbytes` is greater than 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants