Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Enterprise repo URL issue #725

Closed
john777is opened this issue May 19, 2022 · 2 comments · Fixed by #809
Closed

Github Enterprise repo URL issue #725

john777is opened this issue May 19, 2022 · 2 comments · Fixed by #809

Comments

@john777is
Copy link

john777is commented May 19, 2022

Hello,

I have a problem with the Github (Enterprise instance) Sync feature, it looks like the plugin is trying to use an incorrect URL pattern which doesn't match the one which is used in the enterprise instance of Github. So the //repos and //branches parts are being added, in my case it should be: github.domain.com/design-system/tokens-v2/ but instead it tries to connect to github.domain.com/design-system//repos/tokens-v2//branches. Changing the value in the baseURL field doesn't help. Please see the details in the attached screenshot from the Add new credentials panel and the dev-tools.

Is it a bug?

Additionally, wanted to ask more about the Enterprise instance of Github, if the repo is behind a firewall and only accessible when client is connected to a VPN, will the plugin be able to access the repo?

issue-1

issue-2

@john777is john777is changed the title Github Enterprise Sync issue Github Enterprise repo URL issue May 19, 2022
@six7
Copy link
Collaborator

six7 commented May 19, 2022

Change baseUrl to be https://github.xyz.com/api/v3 and your Repository to be design-system/tokens-v2 - this should do the trick.

@john777is
Copy link
Author

Change baseUrl to be https://github.xyz.com/api/v3 and your Repository to be design-system/tokens-v2 - this should do the trick.

It worked! Thank You for such an amazing plugin 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants