Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab: creating a new folder structure from the plugin doesn't work. #3076

Closed
5 tasks done
rbosker opened this issue Aug 16, 2024 · 2 comments · Fixed by #3089
Closed
5 tasks done

Gitlab: creating a new folder structure from the plugin doesn't work. #3076

rbosker opened this issue Aug 16, 2024 · 2 comments · Fixed by #3089
Assignees
Labels
2.0-followup bug Something isn't working

Comments

@rbosker
Copy link
Collaborator

rbosker commented Aug 16, 2024

Describe the bug

  • ❌Gitlab: creating a new folder structure from the plugin doesn't work.
  • ✅ connecting to an existing folder works
  • ✅ creating and syncing to a single file works

To Reproduce
Steps to reproduce the behavior:

  1. Setup Gitlab
  2. Use as path a folder that doesn't exist
  3. You will get a 404 and the folder isn't created.
    image

Acceptance criteria

  • Users should be able to push to a new branch when editing the sync provider details (i.e. from main to new-branch)
  • New branch created should be based on the current one that's selected in the plugin
  • New branch created should be selected and visible in the branch switcher
  • Users should be able to push to a single new file or a new folder when editing the sync provider details (i.e. change from tokens.json to theme)
  • If the user does not complete the "Push to remote" flow, the sync provider details should revert to the original ones
@rbosker rbosker added bug Something isn't working 2.0-followup labels Aug 16, 2024
@six7 six7 moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Aug 19, 2024
@cuserox cuserox self-assigned this Aug 19, 2024
@cuserox cuserox moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Aug 19, 2024
@cuserox cuserox moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Aug 20, 2024
@cuserox
Copy link
Contributor

cuserox commented Aug 20, 2024

👋 @rbosker the fix is ready to be reviewed (🔨 while I update tests) - #3089 🙏

@github-project-automation github-project-automation bot moved this from 👀 Needs review to ✅ Done in Tokens Studio for Figma Roadmap Aug 22, 2024
@cuserox
Copy link
Contributor

cuserox commented Aug 22, 2024

This has now been merged to the main branch 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-followup bug Something isn't working
Projects
Status: ✅ Done
2 participants