Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button loses unsaved local changes #1216

Closed
esthercheran opened this issue Aug 23, 2022 · 1 comment · Fixed by #1228
Closed

Update button loses unsaved local changes #1216

esthercheran opened this issue Aug 23, 2022 · 1 comment · Fixed by #1228
Assignees
Labels
bug Something isn't working

Comments

@esthercheran
Copy link
Collaborator

Describe the bug
Unsaved local changes are lost when update button is clicked and plugin is re-opened

To Reproduce
Steps to reproduce the behavior:

  1. Connect to a remote storage. Create a new token or edit a token
  2. Click on the Update button
  3. Close the plugin without pushing the changes to remote and restart it
  4. The dialog to recover local changes does not appear and the changes are no-longer available

Expected behavior
On restarting the plugin, if there is any changes that are not pushed to remote the dialog to recover local changes should appear. On clicking Yes the changes should be available

Screenshots or Screencasts

Screen.Recording.2022-08-23.at.12.09.35.PM.mov
@six7 six7 added the bug Something isn't working label Aug 24, 2022
@six7
Copy link
Collaborator

six7 commented Aug 26, 2022

@swordEdge let's work on this from main so we can release this before the next major release. This feels like something that is causing frustration.

@swordEdge swordEdge self-assigned this Aug 26, 2022
@swordEdge swordEdge linked a pull request Aug 26, 2022 that will close this issue
@six7 six7 closed this as completed in #1228 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants