Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support recognizing inline-code on pressing enter #5042

Closed
fundon opened this issue Oct 17, 2023 · 2 comments · Fixed by #5226
Closed

Support recognizing inline-code on pressing enter #5042

fundon opened this issue Oct 17, 2023 · 2 comments · Fixed by #5226
Labels
good first issue Good for newcomers help wanted mod:hotkey Module: related to hotkey binding type:feat Non-bug feature improvements

Comments

@fundon
Copy link
Contributor

fundon commented Oct 17, 2023

Screen.Recording.2023-10-17.at.20.25.07.mov
@github-project-automation github-project-automation bot moved this to 🆕 New in AFFiNE Project Oct 17, 2023
@doodlewind doodlewind added type:bug Something isn't working mod:hotkey Module: related to hotkey binding labels Oct 18, 2023
@doodlewind
Copy link
Member

How about pressing space at the end of first line? This should trigger markdown recognition.

@fundon
Copy link
Contributor Author

fundon commented Oct 18, 2023

How about pressing space at the end of first line? This should trigger markdown recognition.

Yes, it works.

@doodlewind doodlewind changed the title inline-code does not behave as expected when pressing enter key Support recognizing inline-code on pressing enter Oct 18, 2023
@doodlewind doodlewind added good first issue Good for newcomers type:feat Non-bug feature improvements help wanted and removed type:bug Something isn't working labels Oct 18, 2023
@AyushAgrawal-A2 AyushAgrawal-A2 mentioned this issue Nov 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in AFFiNE Project Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted mod:hotkey Module: related to hotkey binding type:feat Non-bug feature improvements
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(page): enter key also triggers inline style formatting AyushAgrawal-A2/blocksuite
2 participants
@fundon @doodlewind