-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to null-safety #607
Conversation
Hi, could this issue get more priority, please? It is the last not null-safe package for my project and I would like to migrate. Thanks in advance! |
@mendoxe If you want to migrate use this: dependency_overrides:
mapbox_gl:
git:
url: https://github.com/morvagergely/flutter-mapbox-gl.git
mapbox_gl_platform_interface:
git:
url: https://github.com/morvagergely/flutter-mapbox-gl.git
path: mapbox_gl_platform_interface
mapbox_gl_web:
git:
url: https://github.com/morvagergely/flutter-mapbox-gl.git
path: mapbox_gl_web |
@andrea689 Thank you, sir. Btw. may I ask why isn't the package being migrated and one has to do a workaround like this? |
@mendoxe This is a community driven project, so the PR will be merged and a new version released when the maintainer has some time to do it. In the meantime, you can use the fork directly and proceed with the migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I've tested this branch with my own app and haven't run into any issues. And it's nice to see a few latent bugs being fixed along the way.
I have a few comments and questions here.
Also, for other reviewers, I did not look at changes to examples and the web platform code. Someone who know the web codebase may want to take a closer look at that.
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
mapbox_gl_platform_interface/lib/src/method_channel_mapbox_gl.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but as I mentioned I didn't review the web platform code
I've tried my apps (Android iOS and web) with this branch and there doesn't seem to be any problems. @tobrun I think you should merge this PR as soon as possible so that the next developments can be done on an NNBD basis. |
Any plan on releasing a new version to pub which includes this pr? @andrea689 ? |
@tobrun makes the releases |
yes, I need to find a way for collaborators to be able to do this as well. Initially thinking to add collaborators with write access, now thinking about setting up a CD pipeline through git tags.. |
Would appreciate any update on this @tobrun. Were you able to set up a CD pipeline or manually release it to the pub? |
Also interested into getting this PR released! |
any news regarding null-safety release? |
This commit migrates all packages to null-safety. Solves #564.
Also updates dependencies.
Android compile SDK version changed from 28 to 29 and multidex support has been enabled.
queryRenderedFeatures
now works on web.