Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling specific parts of a list thats being rendered #22

Closed
macangular opened this issue Oct 26, 2018 · 14 comments
Closed

Calling specific parts of a list thats being rendered #22

macangular opened this issue Oct 26, 2018 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@macangular
Copy link

Is there a way to target specific parts of a list that is getting loaded from typescript. For example, making a list of field names in typescript and on the html just looping through the form and getting the different fields to show but with joyride i wanna say target just the first name field then another one rather then the whole div thats rendering it.

@tnicola
Copy link
Owner

tnicola commented Oct 29, 2018

Hi @macangular ! I'd be glad to help you but I'm not sure to have understood your point here. Do you need to target only the text, without the entire div background? If you need to loop for all your fieldsyou can with the joyride. Can you give me an example?

@macangular
Copy link
Author

Hi @tnicola after trying to debug for 4 days i eventually realized i can can make an array and go through it and while going through it set it to the ngx-joyride and now it can iterate through a dynamic list.

However, I do have 1 question. Is it possible for the joyride to scroll down a page while giving a tour? because im having trouble with the joyride only showing a tour on whats on the page without scrolling.

@macangular
Copy link
Author

Also, is there a way to add more left-padding to the white tour box because its really close to the text?

@tnicola
Copy link
Owner

tnicola commented Oct 30, 2018

Do you think that documentation should be improved?

The joyride should scroll automatically to the target every time you move to the next step. Doesn't it scroll for you?

For the padding and the styles more in general you can override the css of the library. e.g:

.joyride-step__container {
     padding: 20px;
}

@macangular
Copy link
Author

I think the documentation is good but can be improved so that some people would know that ngx-joyride can be used in a dynamic list situation.

Also, no the joyride doesn't automatically scroll. Whatever is showing on the page (without scrolling) works perfectly by showing you all the steps and moving to them but when it reaches the bottom and needs to scroll it just doesn't scroll but the joyride i'm assuming is still working because the joyride didn't crash and was letting me go to the next step just couldn't see where its highlighting over.

Thank you for the padding overriding i'll give that a try.

@ghost
Copy link

ghost commented Nov 7, 2018

auto-scroll doesn't work on my project either (I'm using Angular7 if this info helps). My target is way down the page so when the page loads I can only see the backdrop.

@tnicola
Copy link
Owner

tnicola commented Nov 9, 2018

Sorry about the delay!I'll find out why auto-scrolling doesn't work.

@sublimator
Copy link

Neat lib @tnicola! Also seeing some auto scrolling issues, and also using angular v7

@tnicola tnicola added the bug Something isn't working label Nov 12, 2018
@tnicola
Copy link
Owner

tnicola commented Nov 13, 2018

Guys, I've tried with Angular 7, auto-scrolling works fine for me. Can you add more details on your issue?
Browser, Browser version, other libraries you're using, is it the first/last step in your tour? Can you reproduce it on stackblitz? I'll continue the investigation in the meanwhile.

@sublimator
Copy link

sublimator commented Nov 13, 2018 via email

@macangular
Copy link
Author

Hi, the way i was doing it that i was having the joyride not scroll was having the header and footer static and the body in the middle has a list that is getting the information for the list from the typescript side. The body i believe also had its own independent scrolling rather than the window scrolling.

@tnicola tnicola self-assigned this Nov 15, 2018
@tnicola
Copy link
Owner

tnicola commented Nov 25, 2018

Hi all,
Sorry for the delay, I sorted out what was the problem, I was taking in account only the window scroll. Now the auto-scroll should work on all the scrollable items. Try it out in the new version 2.2.2
Thanks for the feedbacks!

@sublimator
Copy link

sublimator commented Nov 26, 2018 via email

@macangular
Copy link
Author

Hi Tnicola,
Thank you for the response back and fixing the issue. I'll go ahead and try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants