-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reveal multiple rangesets with one rangeset. #664
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #664 +/- ##
==========================================
+ Coverage 55.76% 56.22% +0.45%
==========================================
Files 189 189
Lines 20886 20854 -32
==========================================
+ Hits 11648 11725 +77
+ Misses 9238 9129 -109 ☔ View full report in Codecov by Sentry. |
df4b31a
to
5cf7128
Compare
This doesn't address the issue, we're not looking for a method to pass in a slice. Instead, we want to address the problem that the user has to specify each range individually which corresponds to a commitment. When the user provides a range set to reveal, we should look into the encoding tree/hash commitments and determine if we can satisfy it with one or more of the available commitments. |
Yeap! Got the same feedback from @themighty1 , and am working on it |
I'm sorry @yuroitaki , I left my comment above a few days ago but gh still had it as "pending". Apparently i am not able to leave a single comment without explicitely marking the review as "request changes". |
// Lookup by transcript index. | ||
transcript_idxs: HashMap<Idx, usize>, | ||
// Lookup by transcript direction and index. | ||
transcript_idxs: HashMap<(Direction, Idx), usize>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: Direction
needs to be stored alongside Idx
as the latter doesn't contain any direction info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, i'll open an issue lest we forget (but i think this bug was already addressed in one of the open PRs, or maybe it's in my local wip review branch.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i actually also fixed this bug in this PR itself
Addresses #655