Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use python for the GCM implementation with PyCrypto aesgcm #301

Closed
tomato42 opened this issue Jul 31, 2018 · 1 comment
Closed

Don't use python for the GCM implementation with PyCrypto aesgcm #301

tomato42 opened this issue Jul 31, 2018 · 1 comment
Labels
invalid

Comments

@tomato42
Copy link
Member

the current tlslite/utils/pycrypto_aesgcm.py uses pure python implementation for the GCM integrity mechanism, pycrypto actually does support GCM natively. Change code to use it.
@tomato42 tomato42 added enhancement new feature to be implemented help wanted labels Jul 31, 2018
@tomato42 tomato42 added this to the someday/future milestone Jul 31, 2018
This was referenced Jul 31, 2018
Closed
Open
@tomato42 tomato42 removed this from the someday/future milestone Nov 28, 2019
@tomato42 tomato42 added invalid and removed enhancement new feature to be implemented help wanted labels Nov 28, 2019
@tomato42
Copy link
Member Author

correction, only the unreleased version of pycrypto implements GCM and the project is dead, so the pycrypto_aesgcm.py already does basically the best effort for implementing AES-GCM with pycrypto.

(there may be ways to make it faster, but they do not involve using pycypto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomato42