This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
fix: Fix js error when clicking on a tab #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 99.33% (diff: 100%)@@ master #376 diff @@
==========================================
Files 107 107
Lines 2114 2114
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2100 2100
Misses 14 14
Partials 0 0
|
|
I am still seeing this issue in the latest npm package 1.7.2. Is there any other workaround for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347
MDL tabs require a
hrefto be set, so we're using a small hack to make it work without MDL errors.