Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Fixes programmatic handling of checkboxes #136

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

noisecapella
Copy link
Contributor

This is related to #58 and mostly adapted from this commit fixing the problem for Switch: 3078783

@tleunen
Copy link
Owner

tleunen commented Nov 30, 2015

Thanks @noisecapella. Could you please fix these eslint errors?

react-mdl/src/Checkbox.js
  27:9  error  Expected indentation of 6 space characters but found 8  indent
  29:9  error  Expected indentation of 6 space characters but found 8  indent
  33:9  error  Expected indentation of 6 space characters but found 8  indent
  43:5  error  Expected indentation of 2 space characters but found 4  indent

The others 2 errors are unrelated to this commit and I'll fix them later

@noisecapella
Copy link
Contributor Author

Just pushed!

By the way it seems like similar changes would be needed for Radio and possibly other components

@tleunen
Copy link
Owner

tleunen commented Dec 1, 2015

Indeed, the other "input fields" could have the same issue.. I'll try to take a look in the next days

tleunen added a commit that referenced this pull request Dec 1, 2015
Fixes programmatic handling of checkboxes
@tleunen tleunen merged commit 16da125 into tleunen:master Dec 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants