This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Add "env" support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleunen
force-pushed
the
jgkim-env-support
branch
from
0abf436
to
f7481b5
Compare
tleunen
force-pushed
the
jgkim-env-support
branch
from
f7481b5
to
198b1e2
Compare
Current coverage is 100% (diff: 100%)@@ master #19 diff @@
===================================
Files 1 1
Lines 21 30 +9
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 21 30 +9
Misses 0 0
Partials 0 0
|
|
Thank you for informing me, @tleunen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed a bit your initial implementation @jgkim from #16, because the configuration from the specific environment should be merged into the default configuration instead of overriding it.