Pass filename to PostCSS correctly #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 90.26% 90.29% +0.03%
==========================================
Files 20 20
Lines 966 969 +3
Branches 261 261
==========================================
+ Hits 872 875 +3
Misses 76 76
Partials 18 18
Continue to review full report at Codecov.
|
tkh44
reviewed
Aug 8, 2017
| const prefixedStyle = expandCSSFallbacks(prefixer(style)) | ||
| const parsedStyle = postcssJs.parse(style) | ||
| parsedStyle.source = {} | ||
| parsedStyle.source.input = new Input(parsedStyle.toString(), { |
tkh44
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
What:
Pass filename to PostCSS correctly so browserslist can read configs correctly.
Why:
#242
How:
For tagged template literals: don't objectify the root node before passing it to the prefixer so that source nodes remain.
For objects: create an
Inputobject and set it on the root node before passing it to the prefixer. (it's pretty hacky)Checklist: