fresh regex every time extractCritical is called #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 89.11% 89.13% +0.02%
==========================================
Files 22 22
Lines 845 847 +2
Branches 219 219
==========================================
+ Hits 753 755 +2
Misses 70 70
Partials 22 22
Continue to review full report at Codecov.
|
emmatown
approved these changes
Jul 25, 2017
tkh44
reviewed
Jul 25, 2017
src/server.js
Outdated
| @@ -16,6 +14,8 @@ export { | |||
| export function extractCritical (html) { | |||
| // parse out ids from html | |||
| // reconstruct css/rules/cache to pass | |||
| const RGX = /css(?:[a-zA-Z0-9-]*)-([a-zA-Z0-9]+)/gm | |||
|
|
|||
There was a problem hiding this comment.
Do we need to do RGX.lastIndex = 0 after the while loop?
There was a problem hiding this comment.
nyah, it gets GCed and lost anyway after it's done
There was a problem hiding this comment.
What about its usage here though. https://github.com/tkh44/emotion/pull/177/files/737e2b32325571d1dec2da461222aa995981e091#diff-e6a5b42b2f7a26c840607370aed5301aR29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Use a fresh regex every time
extractCriticalis calledWhy: regexes are stateful, and the current method would break critical css extraction unexpectedly because of previous runs
How: the regex declaration was brought inside the function
Checklist: