Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide VR Mode button #168

Closed
Commenter25 opened this issue Jul 6, 2023 · 4 comments · Fixed by #175
Closed

Add option to hide VR Mode button #168

Commenter25 opened this issue Jul 6, 2023 · 4 comments · Fixed by #175

Comments

@Commenter25
Copy link

Similar to the Big Picture button, there is a VR button which always displays. This used to only appear when a headset was actively plugged in, but this seems to no longer be the case. Since there is already an option to hide the Big Picture button, it makes sense to have an option to hide this too.

Screenshot displaying the VR mode button in the top right of the window

@Foldex
Copy link
Contributor

Foldex commented Jul 8, 2023

image

Can't seem to reproduce, granted I don't have a VR headset to begin with.
This sounds more like a steam client bug to me, with the button display somehow remaining enabled when it shouldn't.

As for an option to disable it, I'm against it. It'd be one thing if it displayed for every user regardless of VR support, but that doesn't seem to be the case. It wouldn't make much sense to hide a button that only shows up for VR users, which presumably has useful functionality for them. Even accounting for this bug, it would be very inconvenient that anytime you actually do want access to the button, you'd have to repatch, restart steam, and then repatch/restart again to disable it after you're done with it.

@Commenter25
Copy link
Author

Perhaps if you install and launch SteamVR, it will appear?

I disagree about that. Big Picture can still be opened by other methods without the button for it. Likewise, VR Mode can be activated without that button. All it does is launch SteamVR, which is also an app in the library. And there's also a button in the same menus that let you launch Big Picture. With the rarity I open VR, I would rather hide that button for UI cleanliness, and just go to SteamVR in my library if I need to. Technically I wouldn't even need to do that, as launching a VR game automatically opens SteamVR.

@Foldex
Copy link
Contributor

Foldex commented Jul 8, 2023

Perhaps if you install and launch SteamVR, it will appear?

Still nope. 🤷

Likewise, VR Mode can be activated without that button. All it does is launch SteamVR, which is also an app in the library. And there's also a button in the same menus that let you launch Big Picture. With the rarity I open VR, I would rather hide that button for UI cleanliness, and just go to SteamVR in my library if I need to. Technically I wouldn't even need to do that, as launching a VR game automatically opens SteamVR.

I presumed it would've had exclusive functionality, but if that's the case then I guess my fears were unfounded.

git clone https://github.com/Foldex/Adwaita-for-Steam.git -b hide_vr_button
./install.py -we topbar/hide_vr

If you can test to make this this works, I'll open the PR.

@Commenter25
Copy link
Author

Can confirm that it works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants