Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release latest #70

Closed
dcousens opened this issue May 11, 2016 · 11 comments
Closed

Release latest #70

dcousens opened this issue May 11, 2016 · 11 comments

Comments

@dcousens
Copy link
Contributor

dcousens commented May 11, 2016

edit: We really need to get the update out ASAP, as iOS crashes otherwise

@dcousens dcousens self-assigned this May 11, 2016
@dcousens dcousens added this to the 1.3.4 milestone May 11, 2016
@jjbridges
Copy link

Looking forward to these updates.

@tjwoon
Copy link
Owner

tjwoon commented May 19, 2016

Shall we make v1.3.4 contain those fixes which can be done/merged relatively quickly, and leave the stuff which require more time to v1.4.0?

In fact depending on the list of changes to be done, I think it may be better for the upcoming to be v1.4.0 followed by v1.5.0.

@tjwoon
Copy link
Owner

tjwoon commented May 19, 2016

@dcousens
Copy link
Contributor Author

@tjwoon indeed, most of the above should be fixed, I just haven't had time to take it to a number of devices and thoroughly test yet.

@uniphonic
Copy link
Contributor

@tjwoon Sounds good to me, except I think maybe we should leave out #49. I think all of those have code fixes that have already been committed, with the exception of #49, which I was not able to reproduce. Everything else is already in master, correct? I think we should go ahead and release what we've got in master right now.

I just tested it out the latest from master on a Samsung Galaxy S4, Nexus 5x, iPhone 6, and iPhone 4s, and it seems to be working fine for me. I had done more extensive testing on PR #65 , and didn't see any problems there either.

@jjbridges
Copy link

I also have the issue #49, I cannot get the flash to come on. Testing with a Samsung S5. I had my fingers crossed to get that fix in the next release. I have other people stating the same that it doesn't work. This conversation probably should trail into #49 discussion.

@tjwoon
Copy link
Owner

tjwoon commented May 23, 2016

Wow, progress spends awesome!

I'll test #49 on some of my devices

@ichaldeak
Copy link

When could we expect a release with these fixes? Especially fixes #78 and #50 are quite important.

@dcousens
Copy link
Contributor Author

dcousens commented Aug 17, 2016

For me, I have to release this and do a production testing set within the next month (or so).

This was referenced Sep 14, 2016
@dcousens
Copy link
Contributor Author

Related #92

@dcousens dcousens reopened this Nov 11, 2016
@dcousens
Copy link
Contributor Author

Related #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants