Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection for platform OS #4

Open
mhartington opened this issue Sep 17, 2020 · 2 comments
Open

Better detection for platform OS #4

mhartington opened this issue Sep 17, 2020 · 2 comments

Comments

@mhartington
Copy link

Since lua LSP has predictable platforms it builds to, you could do a conditional check and set the bin location

local bin_location = jit.os

if jit.os == 'osx' then 
  local bin_location = 'macOS'
elseif jit.os == 'linux' then --or what ever the value returned by linux
    local bin_location = 'Linux'
....

Just some ideas

@martini97
Copy link

This is what I did to fix the command on Mac: https://gitlab.com/martini97/dot-nvim/-/commit/b6f627ce8ac9c2eeb303237afe3abbf8d9de4a20

@wantyapps
Copy link

This is what I do in my pr! Please note that the macOS jit.os value is in uppercase. Not "osx", but "OSX".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants