Clarify that default option values are persistent

aweebit · web-flow · commit 7fd0b22f1adc · 2023-07-29T09:37:37.000+03:00
diff --git a/lib/command.js b/lib/command.js
@@ -532,10 +532,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
       // --no-foo is special and defaults foo to true, unless a --foo option is already defined
       const positiveLongFlag = option.long.replace(/^--no-/, '--');
       if (!this._findOption(positiveLongFlag)) {
-        this.setOptionValueWithSource(name, option.defaultValue === undefined ? true : option.defaultValue, 'default');
+        this._setPersistentOptionValueWithSource(name, option.defaultValue === undefined ? true : option.defaultValue, 'default');
       }
     } else if (option.defaultValue !== undefined) {
-      this.setOptionValueWithSource(name, option.defaultValue, 'default');
+      this._setPersistentOptionValueWithSource(name, option.defaultValue, 'default');
     }
 
     // register the option

Original file line number	Diff line number	Diff line change
@@ -532,10 +532,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
`532`	`532`	`// --no-foo is special and defaults foo to true, unless a --foo option is already defined`
`533`	`533`	`const positiveLongFlag = option.long.replace(/^--no-/, '--');`
`534`	`534`	`if (!this._findOption(positiveLongFlag)) {`
`535`		`- this.setOptionValueWithSource(name, option.defaultValue === undefined ? true : option.defaultValue, 'default');`
	`535`	`+ this._setPersistentOptionValueWithSource(name, option.defaultValue === undefined ? true : option.defaultValue, 'default');`
`536`	`536`	`}`
`537`	`537`	`} else if (option.defaultValue !== undefined) {`
`538`		`- this.setOptionValueWithSource(name, option.defaultValue, 'default');`
	`538`	`+ this._setPersistentOptionValueWithSource(name, option.defaultValue, 'default');`
`539`	`539`	`}`
`540`	`540`
`541`	`541`	`// register the option`