Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ordering of files and files_ignore changed #1692

Closed
4 tasks done
petteriv-nordic opened this issue Nov 3, 2023 · 1 comment · Fixed by #1693
Closed
4 tasks done

[BUG] Ordering of files and files_ignore changed #1692

petteriv-nordic opened this issue Nov 3, 2023 · 1 comment · Fixed by #1693
Labels
bug Something isn't working

Comments

@petteriv-nordic
Copy link

petteriv-nordic commented Nov 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Ordering of files & files_ignore/files_ignore_from_source_file has changed in a breaking way.
In v39 files_ignore was considered after the files, in v40 files_ignore are considered before files.

What I want to achieve is to include all .yaml files in folder expect some specific ones that I want to ignore.

To Reproduce

    - name: Get changed Workflows
      id: changed-workflows
      uses: tj-actions/changed-files@40526807ee1e208a1a8c1bbe6bd2d1b044ef6368  # v40.0.2
      with:
        files: |
          *.yaml
          *.yml
        files_ignore_from_source_file: changed-workflows_files_to_ignore.txt
        json: true
        path: .github/workflows
        quotepath: false

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

Behavior is not changed.

Relevant log output

v40

2023-11-03T13:27:08.9436425Z ##[debug]Working directory: /runner/_work/actions/actions/.github/workflows
2023-11-03T13:27:08.9437487Z [command]/usr/bin/git rev-parse --is-inside-work-tree
2023-11-03T13:27:08.9454001Z true
2023-11-03T13:27:08.9454614Z ##[debug]Has git directory: true
2023-11-03T13:27:08.9455955Z ##[debug]files ignore from source file: /runner/_work/actions/actions/.github/workflows/changed-workflows_files_to_ignore.txt
2023-11-03T13:27:08.9457508Z ##[debug]files ignore from source files patterns: !lint-actionlint.yaml
2023-11-03T13:27:08.9458171Z ##[debug]!release.yaml
2023-11-03T13:27:08.9458537Z ##[debug]!versioning.yaml
2023-11-03T13:27:08.9459223Z ##[debug]Input file patterns: 
2023-11-03T13:27:08.9459637Z ##[debug]!lint-actionlint.yaml
2023-11-03T13:27:08.9460036Z ##[debug]!release.yaml
2023-11-03T13:27:08.9460378Z ##[debug]!versioning.yaml
2023-11-03T13:27:08.9460712Z ##[debug]*.yaml
2023-11-03T13:27:08.9461010Z ##[debug]*.yml
2023-11-03T13:27:08.9461934Z ##[debug]File patterns: !lint-actionlint.yaml,!release.yaml,!versioning.yaml,*.yaml,*.yml
2023-11-03T13:27:08.9462948Z ##[debug]Yaml file patterns: {}

v39

2023-11-03T13:52:59.7538238Z ##[debug]Working directory: /runner/_work/actions/actions/.github/workflows
2023-11-03T13:52:59.7539347Z [command]/usr/bin/git rev-parse --is-inside-work-tree
2023-11-03T13:52:59.7539944Z true
2023-11-03T13:52:59.7540544Z ##[debug]Has git directory: true
2023-11-03T13:52:59.7541909Z ##[debug]files ignore from source file: /runner/_work/actions/actions/.github/workflows/changed-workflows_files_to_ignore.txt
2023-11-03T13:52:59.7543533Z ##[debug]files ignore from source files patterns: !lint-actionlint.yaml
2023-11-03T13:52:59.7844638Z ##[debug]!release.yaml
2023-11-03T13:52:59.7844996Z ##[debug]!versioning.yaml
2023-11-03T13:52:59.7857742Z ##[debug]Input file patterns: *.yaml
2023-11-03T13:52:59.7858224Z ##[debug]*.yml
2023-11-03T13:52:59.7858548Z ##[debug]!lint-actionlint.yaml
2023-11-03T13:52:59.7858962Z ##[debug]!release.yaml
2023-11-03T13:52:59.7859320Z ##[debug]!versioning.yaml
2023-11-03T13:52:59.7860412Z ##[debug]File patterns: *.yaml,*.yml,!lint-actionlint.yaml,!release.yaml,!versioning.yaml
2023-11-03T13:52:59.7861597Z ##[debug]Yaml file patterns: {}

Has all relevant logs been included?

  • I've included all relevant logs

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@petteriv-nordic petteriv-nordic added the bug Something isn't working label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@petteriv-nordic petteriv-nordic changed the title [BUG] <title> [BUG] Ordering of files and files_ignore changed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant