You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we're using aeson's decode to parse into Value structures, lookup the data field, then union the HashMaps, which is convenient but less efficient than if we parsed the boundaries of the object using the attoparsec combinators, located the data key boundaries, and then just concatenated the bytestrings together at the right point as a Builder (the EncJSON uses this). Here is an example of parsing directly.
The text was updated successfully, but these errors were encountered:
I just feel icky doing performance work when we don't have benchmarks. It's first of all hard to tell if the effort is worth it, and second we don't get to feel good about any big gains we've attained.
@tirumaraiselvan do you have any thoughts on benchmarking as it relates to this feature?
Currently we're using aeson's
decode
to parse intoValue
structures, lookup thedata
field, then union theHashMap
s, which is convenient but less efficient than if we parsed the boundaries of the object using the attoparsec combinators, located thedata
key boundaries, and then just concatenated the bytestrings together at the right point as aBuilder
(theEncJSON
uses this). Here is an example of parsing directly.The text was updated successfully, but these errors were encountered: