paymentRequestWithCardForm freeze after pressing "Done"

[matthiasleitner]

Before I have submitted the issue

[ x] I have read an installation guide
[ x] I know that for an iOS I need to install pods because I've read the installation guide
[x ] I have read a linking guide and checked that everything is OK like in manual linking guide
[ x] I know that before using tipsi-stripe I need to set options for my app as described in usage guide

The problem

After trying to fill out the payment form on paymentRequestWithCardForm and pressing done a spinner is shown infitely. Dialog can't be exited anymore

Environment

• tipsi-stripe version: experimental branch
• Last tipsi-stripe version where the issue was not reproduced (if applicable):
• iOS or Android: iOS
• OS version: 12
• React-Native version: 0.59.10

Links to logs and sources

Create a GIST which is a paste of your full logs or sources, and link them here.
If you are reporting a bug, always include build or error logs!

• ios/Podfile
• android/build.gradle

Screenshots, GIFs (Must to have)

Just drag-and-drop them to this textarea

Code To Reproduce Issue (Good To Have)

[macnibblet]

I think I had the same problem, it's solved by #521 I modified the files for now, but it's not a good solution.

[matthiasleitner]

@macnibblet I already applied those changes, but issue still occurs.

[matthiasleitner]

issue here seems that the delegate changed

from

- (void)addCardViewController:(STPAddCardViewController *)controller didCreateToken:(STPToken *)token completion:(STPErrorBlock)completion {

to

- (void)addCardViewController: (nonnull STPAddCardViewController *)addCardViewController didCreatePaymentMethod:(nonnull STPPaymentMethod *)paymentMethod completion:(nonnull STPErrorBlock)completion {

[fbartho]

Ah! I haven’t been messing with this API on the mistaken assumption that it should have kept working if there were no compilation issues.

The delegate change is a nice catch and I’ll investigate that today.