Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing call to passes.applyAll in unmarshal.go #174

Closed
shabbyrobe opened this issue Mar 31, 2017 · 1 comment
Closed

Missing call to passes.applyAll in unmarshal.go #174

shabbyrobe opened this issue Mar 31, 2017 · 1 comment

Comments

@shabbyrobe
Copy link
Contributor

//msgp:unmarshal ignore MyType doesn't work, the method is still generated. gen/unmarshal.go requires the following change:

--- /dev/null	2017-03-31 14:37:50.937037313 +1100
+++ gen/unmarshal.go	2017-03-31 14:37:57.956748203 +1100
@@ -32,6 +32,10 @@
 	if !u.p.ok() {
 		return u.p.err
 	}
+	p = u.applyall(p)
+	if p == nil {
+		return nil
+	}
 	if !IsPrintable(p) {
 		return nil
 	}
@antoniomo
Copy link

I'm being bitten by this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants