Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Lists triangle bullet list type - made fixed size according design #1736

Merged
merged 1 commit into from
May 11, 2022

Conversation

n1k1t0ss
Copy link
Contributor

@n1k1t0ss n1k1t0ss commented May 6, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Bullet list is changing its size within a font. It looks bigger, than on design size;

What is the new behavior?

Told with designer and made changes: Fix bullet to 0.75rem size; move it down to 1px

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 6, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1736 (4b8e425) into main (7a0db9d) will increase coverage by 1.16%.
The diff coverage is 71.92%.

@@            Coverage Diff             @@
##             main    #1736      +/-   ##
==========================================
+ Coverage   62.00%   63.16%   +1.16%     
==========================================
  Files         694      920     +226     
  Lines        8485    10020    +1535     
  Branches     1657     1936     +279     
==========================================
+ Hits         5261     6329    +1068     
- Misses       2817     3244     +427     
- Partials      407      447      +40     
Flag Coverage Δ
addon-charts 74.42% <56.52%> (-0.27%) ⬇️
addon-doc 25.82% <40.00%> (-0.33%) ⬇️
addon-editor 45.87% <80.00%> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.57% <80.85%> (?)
core 67.44% <87.50%> (-0.02%) ⬇️
kit 63.05% <ø> (+0.09%) ⬆️
summary 63.16% <71.92%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/components/pie-chart/pie-chart.component.ts 82.05% <ø> (ø)
...arts/components/ring-chart/ring-chart.component.ts 64.28% <ø> (ø)
projects/addon-charts/test.ts 100.00% <ø> (ø)
...mmerce/components/input-CVC/input-CVC.component.ts 60.00% <ø> (ø)
...ts/input-card-grouped/input-card-grouped.module.ts 100.00% <ø> (ø)
...erce/components/input-card/input-card.component.ts 66.66% <ø> (ø)
.../components/input-expire/input-expire.component.ts 63.63% <ø> (ø)
projects/addon-commerce/enums/payment-system.ts 100.00% <ø> (ø)
...s/addon-commerce/pipes/currency/currency.module.ts 100.00% <ø> (ø)
...cts/addon-commerce/pipes/currency/currency.pipe.ts 100.00% <ø> (ø)
... and 369 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614e519...4b8e425. Read the comment docs.

@nsbarsukov nsbarsukov changed the title feat(core): Lists triangle bullet list type - made fixed size according design chore(core): Lists triangle bullet list type - made fixed size according design May 6, 2022
@waterplea waterplea merged commit 503d855 into taiga-family:main May 11, 2022
@well-done-bot
Copy link

well-done-bot bot commented May 11, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants